Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart: add container security context #3350

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

viktoriaas
Copy link

This change adds container security context to admission, controller, scheduler Deployments, and scheduler Job. Container security context is necessary in some restricted environments, e.g. in an environment that employs Restricted Pod Security Standard as default.

This PR is just a cleaner version of #3322

this change adds container security context support which might be
required in some restricted environments

Signed-off-by: viktoriaas <viktoria.spisakovaa@gmail.com>
Signed-off-by: viktoriaas <viktoria.spisakovaa@gmail.com>
@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 14, 2024
@viktoriaas
Copy link
Author

@Monokaix opening a new PR featuring the same commits as before to maintain the history.

@viktoriaas
Copy link
Author

/assign @hzxuzhonghu

@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2024
@lowang-bh
Copy link
Member

@viktoriaas please rebase and squash commits to only one.

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2024
@volcano-sh-bot
Copy link
Contributor

@viktoriaas: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants