Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 2957: predicate plugin ut didn't really run due to kubeclient init failed #3341

Merged
merged 1 commit into from
Apr 7, 2024
Merged

fix issue 2957: predicate plugin ut didn't really run due to kubeclient init failed #3341

merged 1 commit into from
Apr 7, 2024

Conversation

lowang-bh
Copy link
Member

Fix #2957(UT didn't really run because of kubeclient init failed)

image

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 9, 2024
@lowang-bh lowang-bh changed the title Issue2957 fix issue 2957: predicate plugin ut didn't really run due to kubeclient init failed Mar 9, 2024
@lowang-bh lowang-bh mentioned this pull request Mar 9, 2024
Closed
4 tasks
@lowang-bh lowang-bh mentioned this pull request Mar 9, 2024
Closed
7 tasks
@lowang-bh
fix: ut didn't really run because init kubeclient failed; remove gomo…
0f9de7f 
…nkey which macos doesn't has permit to run

Signed-off-by: lowang-bh <lhui_wang@163.com>
@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 11, 2024
@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@lowang-bh lowang-bh mentioned this pull request Mar 29, 2024
Closed
@lowang-bh
Copy link
Member Author

/assign @shinytang6 @hzxuzhonghu

william-wang
william-wang approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2024
@volcano-sh-bot volcano-sh-bot merged commit c2101a3 into volcano-sh:master Apr 7, 2024
14 checks passed
@lowang-bh lowang-bh deleted the issue2957 branch April 12, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monokaix Monokaix Monokaix left review comments

@william-wang william-wang william-wang approved these changes

@hudson741 hudson741 Awaiting requested review from hudson741

@shinytang6 shinytang6 Awaiting requested review from shinytang6

Assignees

@william-wang william-wang

@hzxuzhonghu hzxuzhonghu

@Monokaix Monokaix

@shinytang6 shinytang6

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UT didn't really run because of kubeclient init failed
6 participants
@lowang-bh @Monokaix @volcano-sh-bot @william-wang @hzxuzhonghu @shinytang6