Add custome resouce framework #3339
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/XL
Monokaix
force-pushed
the
karmada
branch
7 times, most recently
from
71c8ab9
to
e78dbc1
Compare
Signed-off-by: Xuzheng Chang <changxuzheng@huawei.com>
| { | ||
| name: "custom resource add", | ||
| handlerName: "test", | ||
| sc: &SchedulerCache{ |
There was a problem hiding this comment.
How about use NewDefaultMockSchedulerCache to trigger the mock list/watch process?
There was a problem hiding this comment.
It's not a proper way here, because custom clinet and cache is a independent part, and it needs to provide parameters separately, and NewDefaultMockSchedulerCache is a general function for test.
| @@ -519,27 +527,31 @@ func newSchedulerCache(config *rest.Config, schedulerNames []string, defaultQueu | |||
| nodeQueue: workqueue.NewRateLimitingQueue(workqueue.DefaultControllerRateLimiter()), | |||
| DeletedJobs: workqueue.NewRateLimitingQueue(workqueue.DefaultControllerRateLimiter()), | |||
| kubeClient: kubeClient, | |||
| dynClient: dynamic.NewForConfigOrDie(config), | |||
There was a problem hiding this comment.
also need init fake client in newMockSchedulerCache.
|
/lgtm |
|
@Vacant2333: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
volcano-sh-bot
added
the
needs-rebase
|
@Monokaix: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add custome resouce framework.
Based on #2760 but made some optimizations.
Part of #3310