Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure deletion of pods is handled #2784

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Conversation

Monokaix
Copy link
Member

@Monokaix Monokaix commented Apr 13, 2023

/kind bug

When a watch pod deletion event was missed while disconnected from apiserver, delta fifo in informer will generate a new delete event, and a DeletedFinalStateUnknown obj will be enqueue and reprocessed, here is this logic:
https://github.com/kubernetes/kubernetes/blob/297dc976b96895332f8e800c531f47d5cca68bfd/staging/src/k8s.io/client-go/tools/cache/delta_fifo.go#L665

We have considered the case in DeletePod event handler:

case cache.DeletedFinalStateUnknown:
but not in filter func, which will lead event handler have no chance to handle pod deletion miss event, so we should check in filter func first.

Signed-off-by: Xuzheng Chang <changxuzheng@huawei.com>
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 13, 2023
@jiangkaihua
Copy link
Contributor

/lgtm Thank you for contribution!

Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@volcano-sh-bot volcano-sh-bot merged commit ee79957 into volcano-sh:master Apr 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants