Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add keyword about allocate/pipeline/evict information in log #2776

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Apr 11, 2023

add key word about allocate/pipeline/evict information in log.

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2023
@lowang-bh
Copy link
Member Author

/assign @shinytang6

@wangyang0616
Copy link
Member

It's ok to me, please help to review.
cc @william-wang @jiangkaihua

@lowang-bh
Copy link
Member Author

reopen.

@lowang-bh
Copy link
Member Author

Hi, @Thor-wl and @merryzhou , would you please help to review this pr? thanks.

@jiangkaihua
Copy link
Contributor

/lgtm

Maybe we need to make the CI happy first. @wangyang0616

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2023
…allocate/unpipeline/unevict

Signed-off-by: lowang_bh <lhui_wang@163.com>
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@lowang-bh
Copy link
Member Author

Hi, @william-wang would you please help to review this pr and merge it? Thanks.

@lowang-bh lowang-bh changed the title improve: show detail statement log when allocate/pipeline/evict or un… enhancement: add keyword about allocate/pipeline/evict information in log May 31, 2023
@lowang-bh
Copy link
Member Author

/assign @william-wang

Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@volcano-sh-bot volcano-sh-bot merged commit 300cc2c into volcano-sh:master Jun 2, 2023
13 checks passed
@lowang-bh lowang-bh deleted the logimprove branch June 7, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants