Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: high priority job of two tasks cannot preempt low priority job of one task #2775

Merged
merged 1 commit into from
May 23, 2023
Merged

fix: high priority job of two tasks cannot preempt low priority job of one task #2775

merged 1 commit into from
May 23, 2023

Conversation

wangyang0616
Copy link
Member

fix: #2772

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2023
@LivingCcj LivingCcj mentioned this pull request Apr 14, 2023
Closed
@wangyang0616
Copy link
Member Author

/priority important-soon

@volcano-sh-bot volcano-sh-bot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 18, 2023
@wangyang0616
When the victim information is judged to be empty at one time, it doe…
5939cc1 
…s not necessarily prevent the scheduling of the preemptor task

Signed-off-by: wangyang <wangyang8126@gmail.com>
hwdef
hwdef reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It‘s OK to me
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2023
william-wang
william-wang approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@volcano-sh-bot volcano-sh-bot merged commit f27c29b into volcano-sh:master May 23, 2023
13 checks passed
@wangyang0616 wangyang0616 mentioned this pull request Jul 29, 2023
Closed
@yuyue9284 yuyue9284 mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@william-wang william-wang william-wang approved these changes

@merryzhou merryzhou Awaiting requested review from merryzhou

@zen-xu zen-xu Awaiting requested review from zen-xu

Assignees

@william-wang william-wang

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

high priority job of two tasks cannot preempt low priority job of one task
4 participants
@wangyang0616 @volcano-sh-bot @william-wang @hwdef