Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allocate-action.md doc #2771

Closed
wants to merge 1 commit into from
Closed

Add allocate-action.md doc #2771

wants to merge 1 commit into from

Conversation

zbbkeepgoing
Copy link
Contributor

Allocate action doc not exist in design doc, so add it.

add allocate action doc
a1accb2 
Signed-off-by: Binbin Zou <binbin.zou@kyligence.io>

update doc

Signed-off-by: Binbin Zou <binbin.zou@kyligence.io>

remove line

Signed-off-by: Binbin Zou <binbin.zou@kyligence.io>
@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2023
@wangyang0616
Copy link
Member

At present, e2e may fail to download the pytorch image, which leads to CI failure. Can it be triggered to run CI once in the background?
cc @william-wang

@stale
Copy link

stale bot commented Jun 10, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2023
@hwdef
Copy link
Member

hwdef commented Jun 11, 2023

please retrigger the CI, I think the CI is OK now.
I think the allocate action is the most important action, and its documentation should be more comprehensive.

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2023
@zbbkeepgoing zbbkeepgoing reopened this Jun 12, 2023
@stale
Copy link

stale bot commented Aug 12, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 12, 2023
@stale stale bot closed this Sep 17, 2023
@hwdef
Copy link
Member

hwdef commented Sep 17, 2023

/reopen

@volcano-sh-bot
Copy link
Contributor

@hwdef: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wpeng102
You can assign the PR to them by writing /assign @wpeng102 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lowang-bh
lowang-bh reviewed Sep 17, 2023
View reviewed changes
docs/design/allocate-action.md
7. PredicateFn(Plugin: Predicates),
8. BatchNodeOrderFn(Plugin: NodeOrder)

### 1. NamespaceOrderFn:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one has been removed.

@stale stale bot removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 17, 2023
@stale Stale
Copy link

stale bot commented Dec 15, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2023
@stale stale bot closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowang-bh lowang-bh lowang-bh left review comments

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@k82cn k82cn Awaiting requested review from k82cn

Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. retest-not-required-docs-only size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zbbkeepgoing @wangyang0616 @hwdef @volcano-sh-bot @lowang-bh