Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jobflow controller code #2559

Merged
merged 3 commits into from
May 23, 2023
Merged

add jobflow controller code #2559

merged 3 commits into from
May 23, 2023

Conversation

zhoumingcheng
Copy link
Contributor

Signed-off-by: zhoumingcheng zhoumingcheng@beyondcent.com

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 1, 2022
@zhoumingcheng zhoumingcheng force-pushed the jobflow-controller branch 2 times, most recently from e346b8c to a8bd3e9 Compare November 2, 2022 01:55
@zhoumingcheng zhoumingcheng reopened this Nov 2, 2022
hwdef
hwdef reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Generally looks good.
I think we can unify the cache in the controller later to reduce memory usage.

pkg/controllers/jobflow/constant.go Outdated Show resolved Hide resolved
pkg/controllers/jobflow/constant.go Outdated Show resolved Hide resolved
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
Thor-wl
Thor-wl reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhoumingcheng hey. Can you separate the PR into some small ones for it is too large to review?

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@zhoumingcheng zhoumingcheng reopened this Nov 24, 2022
@zhoumingcheng zhoumingcheng reopened this Nov 24, 2022
@zhoumingcheng
Copy link
Contributor Author

@zhoumingcheng hey. Can you separate the PR into some small ones for it is too large to review?

Thank you for your suggestion. I have broken the code into three parts: controller, e2e test, and webhook. I will give priority to submitting the code of the controller.

1 similar comment
@zhoumingcheng
Copy link
Contributor Author

@zhoumingcheng hey. Can you separate the PR into some small ones for it is too large to review?

Thank you for your suggestion. I have broken the code into three parts: controller, e2e test, and webhook. I will give priority to submitting the code of the controller.

@zhoumingcheng zhoumingcheng changed the title add jobflow code,unit test,e2e test add jobflow controller code Dec 13, 2022
@zhoumingcheng zhoumingcheng reopened this Jan 31, 2023
@stale
Copy link

stale bot commented Apr 2, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2023
@wangyang0616
Copy link
Member

Keep current PR
/remove-lifecycle stale

@volcano-sh-bot volcano-sh-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2023
@zhoumingcheng
resolved conflict
ba86a25 
Signed-off-by: zhoumingcheng <zhoumingcheng@beyondcent.com>
@volcano-sh-bot
Copy link
Contributor

@zhoumingcheng: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hwdef
hwdef reviewed Apr 7, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I think we can move on to this work.

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2023
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2023
@zhoumingcheng zhoumingcheng reopened this Apr 7, 2023
@zhoumingcheng
resolved conflict
67e339c 
Signed-off-by: zhoumingcheng <zhoumingcheng@beyondcent.com>
@zhoumingcheng zhoumingcheng reopened this Apr 7, 2023
hwdef
hwdef reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2023
@wangyang0616
Copy link
Member

/priority important-soon

@volcano-sh-bot volcano-sh-bot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 18, 2023
william-wang
william-wang approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@volcano-sh-bot volcano-sh-bot merged commit a2be4a2 into volcano-sh:master May 23, 2023
22 of 23 checks passed
This was referenced May 23, 2023
Merged
Open
@lowang-bh
Copy link
Member

lowang-bh commented May 27, 2023 •
edited

There is no jobflow crd under installer/helm/chart/volcano/crd
see issue #2867

@lowang-bh lowang-bh mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@Thor-wl Thor-wl Thor-wl left review comments

@william-wang william-wang william-wang approved these changes

@qiankunli qiankunli Awaiting requested review from qiankunli

Assignees

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/contains-merge-commits lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zhoumingcheng @wangyang0616 @volcano-sh-bot @lowang-bh @william-wang @hwdef @Thor-wl