Bump to 9.1.0-alpha #8833
Open
Bump to 9.1.0-alpha #8833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ | |||
| "description": "deck.gl layers that aggregate the input data into alternative representations", | |||
| "license": "MIT", | |||
| "type": "module", | |||
| "version": "9.0.0-beta.11", | |||
| "version": "9.1.0-alpha.0", | |||
There was a problem hiding this comment.
These are managed by lerna, please don't edit them manually.
| @@ -65,7 +65,8 @@ export default class TriangleLayer extends Layer<_TriangleLayerProps> { | |||
| {name: 'positions', format: 'float32x3'}, | |||
| {name: 'texCoords', format: 'float32x2'} | |||
| ], | |||
| topology: 'triangle-fan-webgl', | |||
| // TODO v9.1 | |||
There was a problem hiding this comment.
What exactly is the todo here?
| dataFormat: 6402, // gl.DEPTH_COMPONENT | ||
| type: 5125 // gl.UNSIGNED_INT | ||
| // dataFormat: 6402, // gl.DEPTH_COMPONENT | ||
| // type: 5125 // gl.UNSIGNED_INT |
There was a problem hiding this comment.
I think you can delete these safely
| @@ -251,8 +251,8 @@ export default class CollisionFilterEffect implements Effect { | |||
| mipmaps: false, | |||
|
|
|||
| // TODO fix getWebGLTextureParameters() in luma to avoid passing deprecated parameters | |||
| dataFormat: 6402, // gl.DEPTH_COMPONENT | |||
| type: 5125 // gl.UNSIGNED_INT | |||
| // dataFormat: 6402, // gl.DEPTH_COMPONENT | |||
There was a problem hiding this comment.
I think you can delete these safely
ibgreen
force-pushed
the
luma91
branch
2 times, most recently
from
7d3246e
to
df4cb35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Background
Change List