wip

visgl · Apr 25, 2024 · 12fe065 · 12fe065
1 parent 9f38616
commit 12fe065
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/modules/core/src/effects/post-process-effect.ts b/modules/core/src/effects/post-process-effect.ts
@@ -1,5 +1,5 @@
 import type {Device, Framebuffer} from '@luma.gl/core';
-import {normalizeShaderModule, ShaderPass} from '@luma.gl/shadertools';
+import {initializeShaderModule, ShaderPass} from '@luma.gl/shadertools';
 
 import ScreenPass from '../passes/screen-pass';
 
@@ -14,7 +14,7 @@ export default class PostProcessEffect<ShaderPassT extends ShaderPass> implement
   constructor(module: ShaderPassT, props: ShaderPassT['props']) {
     this.id = `${module.name}-pass`;
     this.props = props;
-    normalizeShaderModule(module);
+    initializeShaderModule(module);
     this.module = module;
   }
 

diff --git a/modules/core/src/passes/shadow-pass.ts b/modules/core/src/passes/shadow-pass.ts
@@ -36,8 +36,8 @@ export default class ShadowPass extends LayersPass {
       mipmaps: false,
 
       // TODO fix getWebGLTextureParameters() in luma to avoid passing deprecated parameters
-      dataFormat: 6402, // gl.DEPTH_COMPONENT
-      type: 5125 // gl.UNSIGNED_INT
+      // dataFormat: 6402, // gl.DEPTH_COMPONENT
+      // type: 5125 // gl.UNSIGNED_INT
     });
 
     this.fbo = device.createFramebuffer({

diff --git a/modules/core/src/utils/texture.ts b/modules/core/src/utils/texture.ts
@@ -29,7 +29,6 @@ export function createTexture(
   sampler: SamplerProps
 ): Texture | null {
   if (image instanceof Texture) {
-    // @ts-expect-error This type error seems like it shouldn't happen...
     return image;
   } else if (image.constructor && image.constructor.name !== 'Object') {
     // Browser object

diff --git a/modules/extensions/src/collision-filter/collision-filter-effect.ts b/modules/extensions/src/collision-filter/collision-filter-effect.ts
@@ -251,8 +251,8 @@ export default class CollisionFilterEffect implements Effect {
       mipmaps: false,
 
       // TODO fix getWebGLTextureParameters() in luma to avoid passing deprecated parameters
-      dataFormat: 6402, // gl.DEPTH_COMPONENT
-      type: 5125 // gl.UNSIGNED_INT
+      // dataFormat: 6402, // gl.DEPTH_COMPONENT
+      // type: 5125 // gl.UNSIGNED_INT
     });
     this.collisionFBOs[collisionGroup] = device.createFramebuffer({
       id: `collision-${collisionGroup}`,