Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pydeck-carto): Fix missing global for pydeck-carto in 8.9 release #8786

Merged
merged 3 commits into from Apr 16, 2024

Conversation

donmccurdy
Copy link
Collaborator

Patch for the 8.9-release branch, restoring a missing global for the pydeck-carto integration. I've included some known fixes added since the last release as well.

Related:

@donmccurdy donmccurdy requested a review from Jesus89 April 11, 2024 21:13
@donmccurdy donmccurdy changed the title chore(pydeck-carto): Fix missing global for pydeck-carto in 8.9 release fix(pydeck-carto): Fix missing global for pydeck-carto in 8.9 release Apr 11, 2024
@Jesus89
Copy link
Collaborator

Jesus89 commented Apr 12, 2024

In order to use the following change, a deck.gl path version needs to be published in npm:

globalThis.CartoLayerLibrary = CartoUtils;

And then replace Deck.gl version in both pydeck and pydeck-carto (this change can be included in the PR too):

DECKGL_SEMVER = "~8.9.*"
DECKGL_VERSION = "~8.9.*"

@donmccurdy
Copy link
Collaborator Author

donmccurdy commented Apr 15, 2024

Thanks, I've added the ~8.9.* semver range to this PR.

@Pessimistress and @Jesus89, are you both OK with the following next steps?

  1. @donmccurdy to merge this PR
  2. @donmccurdy and/or @felixpalmer to publish a new deckgl v8.9 patch release
  3. @donmccurdy to test pydeck locally against v8.9 patch release
  4. @Jesus89 to complete additional tests (.show()) then publish a pydeck and pydeck-carto v0.8.x release

Context: Current deckgl v8.9 release does not work in pydeck, and pydeck is pinned to v8.8 as a result, but there are fixes in v8.9 that we'd like to get published. We're working toward a pydeck version based on deckgl v9.0, but it is going slowly and may be high risk of regression, for reasons related to pydeck's legacy jupyter bindings. I'd like to eliminate some of the risk by having a working v8.9 release available.

@Jesus89
Copy link
Collaborator

Jesus89 commented Apr 15, 2024

I'm OK with that plan

@donmccurdy
Copy link
Collaborator Author

donmccurdy commented Apr 16, 2024

CI failure to be fixed in:

@donmccurdy donmccurdy force-pushed the donmccurdy/fix-8.9-pydeck-carto branch from 354074d to 03dc64d Compare April 16, 2024 17:57
@donmccurdy donmccurdy merged commit 727c99a into 8.9-release Apr 16, 2024
4 checks passed
@donmccurdy donmccurdy deleted the donmccurdy/fix-8.9-pydeck-carto branch April 16, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants