fix(pydeck-carto): Restore global required by pydeck-carto #8799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
^Never mind previous comment! I do think there are ways to make pydeck custom layers would that would not depend on this global namespace, I think it's better not to change the bundling mechanism at this stage, so lets continue with this PR. |
donmccurdy
force-pushed
the
donmccurdy/fix-carto-pydeck-bundle-global
branch
from
04c74ad
to
ed6282c
Compare
donmccurdy
requested review from
felixpalmer and
Jesus89
and removed request for
felixpalmer and
Jesus89
padawannn
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same thing as #8786, but for deck.gl v9. Name of the global is intentionally changed from CartoLayerLibrary to CartoLibrary, because it now includes sources, and is expected in #8577.