Update Effect interface #8681
Merged
Update Effect interface #8681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/effect-fix-1
branch
from
88a27d9
to
4c3dfb1
Compare
felixpalmer
approved these changes
Mar 20, 2024
| @@ -8,17 +9,32 @@ export type PostRenderOptions = LayersPassRenderOptions & { | |||
| inputBuffer: Framebuffer; | |||
| swapBuffer: Framebuffer; | |||
| }; | |||
| export type EffectContext = { | |||
There was a problem hiding this comment.
device can be obtained from deck. What is the thinking to include them separately? Easier testing?
I see in the followup that deck is needed to add/remove shader modules. If this is the sole purpose of including deck, perhaps it would be better to pass layerManager directly:
export type EffectContext = {
device: Device;
layerManager: LayerManager;
};There was a problem hiding this comment.
Deck.deviceis not public.- It's intentional to route everything through deck, so *manager do not interact with each other directly. If we do change the implementation such as who tracks the shader modules, there will be no breaking change to the effects.
Pessimistress
force-pushed
the
x/effect-fix-1
branch
from
4c3dfb1
to
4ae7d8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8680
Change List
setuplifecycle method for creating GPU resources