Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register default shader module with Deck #8682

Merged
merged 4 commits into from Mar 20, 2024
Merged

Register default shader module with Deck #8682

merged 4 commits into from Mar 20, 2024

Conversation

Pessimistress
Copy link
Collaborator

For #8680

Change List

  • Replace ShaderAssembler.addDefaultModule with a method on Deck class
  • Fix shadow module minor issues
  • Render tests

@Pessimistress Pessimistress force-pushed the x/effect-fix-2 branch 6 times, most recently from 48c1e9f to 51b71fc Compare March 19, 2024 19:15
Base automatically changed from x/effect-fix-1 to master March 20, 2024 18:12
@Pessimistress Pessimistress merged commit 3d57cf7 into master Mar 20, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/effect-fix-2 branch March 20, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pessimistress @felixpalmer