website: Upgrade to Mapbox v3 #8600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
approved these changes
Mar 7, 2024
donmccurdy
approved these changes
Mar 7, 2024
| @@ -43,7 +43,7 @@ class MapboxDemo extends Component { | |||
| } | |||
|
|
|||
| componentDidUpdate(prevProps) { | |||
| if (this.props.data && !prevProps.data) { | |||
| if (this.props.data && !prevProps.data && this._view) { | |||
There was a problem hiding this comment.
It looks like renderToDOM never returns anything ...
... so this._view is never defined? I don't know if it should block this PR, but something seems broken here.
Related:
There was a problem hiding this comment.
I thought renderToDOM is only used when running the example standalone (see index.html in the example's folder), whereas the website imports App directly.
Edit: Oh, nevermind. It mounts the example as a react root within our react website using renderToDOM.. that might be fine, but I see a bug in the signatures. I dropped the data parameter when I ported it. I'll take a look today
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8582 fixes https://felixpalmer.github.io/deck.gl/examples/mapbox
Change List
_viewis uninitialized incomponentDidUpdate