Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples) add mapbox and maplibre get-started examples #8562

Merged
merged 13 commits into from Mar 6, 2024

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Feb 29, 2024

For #8541

Maintain separate mapbox and maplibre getting started examples

Change List

  • maplibre v3 react example
  • mapbox v3 react example
  • mapbox v3 pure-js example

Signed-off-by: Chris Gervang <chris@gervang.com>
@coveralls
Copy link

coveralls commented Feb 29, 2024

Coverage Status

coverage: 70.671%. remained the same
when pulling a2c720d on chr/rename-mapbox-to-maplibre
into bde0ef6 on master.

@Pessimistress
Copy link
Collaborator

Can we have both mapbox and maplibre in get-started examples?

@chrisgervang
Copy link
Collaborator Author

Yeah, I'd like to upgrade the examples to Mapbox v3+

Signed-off-by: Chris Gervang <chris@gervang.com>
@chrisgervang chrisgervang changed the title chore(examples) rename mapbox to maplibre in react chore(examples) add mapbox and maplibre react get-started examples Feb 29, 2024
Signed-off-by: Chris Gervang <chris@gervang.com>
@chrisgervang chrisgervang mentioned this pull request Feb 29, 2024
25 tasks
@chrisgervang chrisgervang changed the title chore(examples) add mapbox and maplibre react get-started examples chore(examples) add mapbox and maplibre get-started examples Feb 29, 2024
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
chrisgervang and others added 6 commits March 1, 2024 10:07
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
@@ -32,7 +33,8 @@ const deckOverlay = new DeckOverlay({
autoHighlight: true,
onClick: info =>
// eslint-disable-next-line
info.object && alert(`${info.object.properties.name} (${info.object.properties.abbrev})`)
info.object && alert(`${info.object.properties.name} (${info.object.properties.abbrev})`),
// beforeId: 'watername_ocean' // In interleaved mode, render the layer under map labels
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pessimistress, FYI added interleaved option

@chrisgervang chrisgervang merged commit 5af293f into master Mar 6, 2024
3 checks passed
@chrisgervang chrisgervang deleted the chr/rename-mapbox-to-maplibre branch March 6, 2024 06:21
@chrisgervang chrisgervang added this to the v9.0 milestone Mar 6, 2024
@chrisgervang chrisgervang self-assigned this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants