Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(examples) Interleaving deck.gl with MapboxOverlay #8555

Merged
merged 4 commits into from Feb 29, 2024

Conversation

chrisgervang
Copy link
Collaborator

For #8541

Background

We currently don't have a pure-js example for using MapboxOverlay with interleaved rendering. Let's add one.

Change List

  • Add mapbox-overlay example to gallery

Signed-off-by: Chris Gervang <chris@gervang.com>
@Pessimistress
Copy link
Collaborator

I think we should just replace the existing mapbox-layer example with this one. The documentation currently recommends using MapOverlay over MapboxLayer as it offers more features.

@chrisgervang
Copy link
Collaborator Author

I think we should just replace the existing mapbox-layer example with this one. The documentation currently recommends using MapOverlay over MapboxLayer as it offers more features.

Hmm, it seems like we're all converging around the idea of removing MapboxLayer from the public api. v9 would be the best time to make a breaking change like that.

MapboxOverlay relies on it internally so I'd keep the implementation as-is, and just remove the export/docs/examples.

Alternately, formally deprecate and move an example to test/apps.

@coveralls
Copy link

coveralls commented Feb 28, 2024

Coverage Status

coverage: 70.643%. remained the same
when pulling b8d2554 on chr/mapbox-overlay-interleave-example
into a5eccec on master.

@chrisgervang chrisgervang merged commit 5339730 into master Feb 29, 2024
2 of 3 checks passed
@chrisgervang chrisgervang deleted the chr/mapbox-overlay-interleave-example branch February 29, 2024 02:07
@chrisgervang chrisgervang mentioned this pull request Mar 6, 2024
25 tasks
@chrisgervang chrisgervang added this to the v9.0 milestone Mar 6, 2024
@chrisgervang chrisgervang self-assigned this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants