New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples/getting-started/react/mapbox to react-map-gl7 #8181
Update examples/getting-started/react/mapbox to react-map-gl7 #8181
Conversation
So now in the examples/get-started dir there is only for mapbox-gl.js/maplibre-gl.js
There's still one last example using react-map-gl 5 in examples/layer-browser (although not as easy to run, because "This is the main testing app for deck.gl development. It can only be run against source on the current branch.") Also
|
Hi @jonenst I'm interested in helping contribute to updating the docs and examples for mapbox and maplibre. Are you still actively working on this? If so, I'd love to collaborate. |
hi @cgalvan |
Thanks for your contributions here and on #8146. The project's been heavily prioritizing core changes in prep for deck v9. I'll be taking upgrading our getting-started examples this week and will review this one as well in the context of v9. |
For #8145
Background
The example previously used
<DeckGL>
as the parent component, but this setup no longer supports controls/plugins in react-map-gl v7. This PR adoptsMapboxOverlay
to insert Deck into the mapbox container and makes<Map>
(aka Mapbox) the parent component. See #8146 for related doc updates.Change List
MapboxOverlay
in the getting started with react+mapbox example.