Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples/getting-started/react/mapbox to react-map-gl7 #8181

Merged

Conversation

jonenst
Copy link
Contributor

@jonenst jonenst commented Oct 7, 2023

For #8145

Background

The example previously used <DeckGL> as the parent component, but this setup no longer supports controls/plugins in react-map-gl v7. This PR adopts MapboxOverlay to insert Deck into the mapbox container and makes <Map> (aka Mapbox) the parent component. See #8146 for related doc updates.

Change List

  • Upgrades react-map-gl to v7
  • Adopts MapboxOverlay in the getting started with react+mapbox example.

@jonenst
Copy link
Contributor Author

jonenst commented Oct 8, 2023

So now in the examples/get-started dir there is only for mapbox-gl.js/maplibre-gl.js

  • one pure js with mapbox 1.x example (examples/get-started/pure-js/mapbox/ )
  • one react-map-gl 7 with maplibre example (examples/get-started/react/mapbox/ )

There's still one last example using react-map-gl 5 in examples/layer-browser (although not as easy to run, because "This is the main testing app for deck.gl development. It can only be run against source on the current branch.")

Also git grep StaticMap or git grep MapContext still return hits, not sure if you want to keep them or clean them up:

docs/api-reference/carto/basemap.md
docs/api-reference/react/deckgl.md
docs/developer-guide/animations-and-transitions.md
docs/developer-guide/view-state-transitions.md
docs/developer-guide/views.md

@cgalvan
Copy link

cgalvan commented Jan 17, 2024

Hi @jonenst I'm interested in helping contribute to updating the docs and examples for mapbox and maplibre. Are you still actively working on this? If so, I'd love to collaborate.

@jonenst
Copy link
Contributor Author

jonenst commented Jan 29, 2024

hi @cgalvan
I'm still interested in this, not sure how to proceed though

@chrisgervang
Copy link
Collaborator

Thanks for your contributions here and on #8146. The project's been heavily prioritizing core changes in prep for deck v9. I'll be taking upgrading our getting-started examples this week and will review this one as well in the context of v9.

@chrisgervang chrisgervang mentioned this pull request Feb 26, 2024
25 tasks
@chrisgervang chrisgervang merged commit 74850d0 into visgl:master Feb 27, 2024
2 checks passed
@chrisgervang chrisgervang added this to the v9.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants