[Bug] v9 LightingEffect and TerrainExtension do not work consistently

[Pessimistress]

Description

In v9 ShaderAssembler took over the v8 ProgramManager’s “default shader module” functionality. However, ProgramManager checks for updates every time before redraw, and ShaderAssembler does not. As a result, default shader modules added after a model is created will be ignored. LightingEffect and TerrainExtension are affected because they need to insert a shader module into every layer (shadow and terrain respectively).

As discussed with @ibgreen, the proposal is to move default module registration into deck. When a change is made, all layers invalidate their models.

Flavors

• Script tag
• React
• Python/Jupyter notebook
• MapboxOverlay
• GoogleMapsOverlay
• CartoLayer
• ArcGIS

Expected Behavior

No response

Steps to Reproduce

Enable the commented out shadow and terrain render tests - the added shader modules do not take effect.

Environment

• Framework version: 9.0.0-beta.9
• Browser:
• OS:

Logs

No response