Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix typo for ReactDOM.prefetchDNS method inside Resource Hints section #65111

Merged
merged 2 commits into from
Apr 29, 2024
Merged

docs: Fix typo for ReactDOM.prefetchDNS method inside Resource Hints section #65111

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62762ba
Fix typo for ReactDOM method inside generate-metadata.mdx
jonathan-ingram Apr 27, 2024
312b559
Remove mention of missing type definitions for ReactDOM
jonathan-ingram Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/02-app/02-api-reference/04-functions/generate-metadata.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,7 +1041,7 @@ ReactDOM.prefetchDNS(href: string)
>
> - These methods are currently only supported in Client Components, which are still Server Side Rendered on initial page load.
> - Next.js in-built features such as `next/font`, `next/image` and `next/script` automatically handle relevant resource hints.
> - React 18.3 does not yet include type definitions for `ReactDOM.preload`, `ReactDOM.preconnect`, and `ReactDOM.preconnectDNS`. You can use `// @ts-ignore` as a temporary solution to avoid type errors.
> - React 18.3 does not yet include type definitions for `ReactDOM.preload`, `ReactDOM.preconnect`, and `ReactDOM.prefetchDNS`. You can use `// @ts-ignore` as a temporary solution to avoid type errors.
Copy link
Member

@eps1lon eps1lon Apr 27, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole line is obsolete now. The types have been available for a while now. We can delete the line instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon Oh wow, great catch, thanks. 馃憤 I've now made those amendments 馃憠 312b559


## Types

Expand Down