docs: Fix typo for ReactDOM.prefetchDNS method inside Resource Hints section
#65111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a typo that incorrectly stated the existence of ReactDOM.preconnectDNS when it should be declared as ReactDOM.prefetchDNS instead.
jonathan-ingram
requested review from
molebox and
StephDietz
and removed request for
a team
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
eps1lon
reviewed
Apr 27, 2024
| @@ -1041,7 +1041,7 @@ ReactDOM.prefetchDNS(href: string) | |||
| > | |||
| > - These methods are currently only supported in Client Components, which are still Server Side Rendered on initial page load. | |||
| > - Next.js in-built features such as `next/font`, `next/image` and `next/script` automatically handle relevant resource hints. | |||
| > - React 18.3 does not yet include type definitions for `ReactDOM.preload`, `ReactDOM.preconnect`, and `ReactDOM.preconnectDNS`. You can use `// @ts-ignore` as a temporary solution to avoid type errors. | |||
| > - React 18.3 does not yet include type definitions for `ReactDOM.preload`, `ReactDOM.preconnect`, and `ReactDOM.prefetchDNS`. You can use `// @ts-ignore` as a temporary solution to avoid type errors. | |||
There was a problem hiding this comment.
This whole line is obsolete now. The types have been available for a while now. We can delete the line instead.
eps1lon
approved these changes
Apr 29, 2024
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65110
Fixed a typo inside the Resource Hints section that incorrectly stated the existence of
ReactDOM.preconnectDNSwhen it should be declared asReactDOM.prefetchDNSinstead.Update: 29th April 2024 - As correctly stated by @eps1lon this line has now been removed completely, as the missing type definitions for
ReactDOMhave been available for a while now. See discussion 馃憠 #65111 (comment)