feat(web-core/tree): enhance tree library #7534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2024
ByScripts
force-pushed
the
web-core/tree-enhancements
branch
from
a397835
to
fa90846
Compare
ByScripts
force-pushed
the
web-core/tree-enhancements
branch
from
05a473b
to
0cb3adc
Compare
This commit changes the way the visibility of tree nodes is determined: - Rename the `isVisible` property to `isExcluded` in `TreeNodeBase`, `Branch` and `Leaf` classes - Add a new `failsFilterDownwards` property in `Branch` and `Leaf` to determine if a node should be excluded - Update the `visibleNodes` computed property to filter out excluded nodes - Modify the `toggleChildrenSelect` method in `Branch` to only toggle non-excluded child nodes
ByScripts
force-pushed
the
web-core/tree-enhancements
branch
from
0cb3adc
to
a2fe755
Compare
OlivierFL
approved these changes
May 22, 2024
|
@pdonias @MathieuRA Can you squash merge? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TreeNodeto allow easy manipulation and initial hydration.activableoption toselectablelabelClassestostatuseshasChildrenonBranchpredicatenow takes theTreeNodeas argument instead ofTDatametaoption, to pass additional arbitrary dataChecklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md