Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-core/tree): tree filter composable #7536

Merged
merged 12 commits into from
May 23, 2024

Conversation

ByScripts
Copy link
Contributor

@ByScripts ByScripts commented Apr 5, 2024

Description

Basic filter on label to be used with tree library.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Rename `collection` to `tree` - Step 1: Rename files and directory
Rename `collection` to `tree` - Step 2: Rename classes and functions
Rename `collection` to `tree` - Step 3: Rename item to node
Rename `collection` to `tree` - Step 4: Rename group to branch
Rename `collection` to `tree` - Step 5: Rename T generic to TData
Rename `collection` to `tree` - Step 6: Rename Definition type to TreeNodeDefinition
Rename `collection` to `tree` - Step 7: Rename remaining collection terms to tree
Rename `collection` to `tree` - Step 8: Update documentation
Rename `collection` to `tree` - Step 9: Code cleaning, renames
@ByScripts ByScripts requested a review from OlivierFL April 5, 2024 09:35
@ByScripts ByScripts self-assigned this Apr 5, 2024
@ByScripts ByScripts force-pushed the web-core/tree-enhancements branch 2 times, most recently from 0cb3adc to a2fe755 Compare May 22, 2024 14:56
Base automatically changed from web-core/tree-enhancements to master May 22, 2024 15:07
@ByScripts ByScripts force-pushed the web-core/tree-filter-composable branch 2 times, most recently from ceda89f to 7b3f368 Compare May 22, 2024 15:19
@ByScripts ByScripts marked this pull request as ready for review May 22, 2024 15:21
# Conflicts:
#	@xen-orchestra/web-core/docs/composables/tree.composable.md
#	@xen-orchestra/web-core/lib/composables/tree.composable.ts
#	@xen-orchestra/web-core/lib/composables/tree/branch.ts
#	@xen-orchestra/web-core/lib/composables/tree/leaf.ts
#	@xen-orchestra/web-core/lib/composables/tree/tree-node-base.ts
#	@xen-orchestra/web-core/lib/composables/tree/types.ts
@ByScripts ByScripts force-pushed the web-core/tree-filter-composable branch from 7b3f368 to 43fa7ff Compare May 22, 2024 15:26
@ByScripts
Copy link
Contributor Author

@pdonias @MathieuRA Can you merge? Thanks.

@MathieuRA MathieuRA merged commit 5cd9e50 into master May 23, 2024
1 check passed
@MathieuRA MathieuRA deleted the web-core/tree-filter-composable branch May 23, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants