Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fastparse to 3.0.2 #519

Merged
merged 9 commits into from Mar 20, 2024
Merged

Update fastparse to 3.0.2 #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bd83d7b
Update fastparse to 3.0.2
typelevel-steward[bot] Jul 18, 2023
8b00211
Revert commit(s) bd83d7b
typelevel-steward[bot] Sep 14, 2023
da41c08
Merge branch 'main' into update/fastparse-3.0.2
typelevel-steward[bot] Sep 14, 2023
814dffb
Update fastparse to 3.0.2
typelevel-steward[bot] Sep 14, 2023
b53d6a2
Revert commit(s) 814dffb
typelevel-steward[bot] Sep 18, 2023
7116409
Merge branch 'main' into update/fastparse-3.0.2
typelevel-steward[bot] Sep 18, 2023
987daac
Update fastparse to 3.0.2
typelevel-steward[bot] Sep 18, 2023
ed90db0
Merge branch 'main' into update/fastparse-3.0.2
regadas Mar 15, 2024
f7d6d36
Disable warnings for unused nowarn
regadas Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions build.sbt
View file
Open in desktop
Expand Up @@ -121,6 +121,7 @@ lazy val bench = project
.settings(
name := "bench",
coverageEnabled := false,
scalacOptions += "-Wconf:cat=unused-nowarn:s",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suppresses this only for bench project

 [error] /home/runner/work/cats-parse/cats-parse/bench/src/main/scala/cats/parse/bench/fastparse.scala:50:43: @nowarn annotation does not suppress any warnings
[error]     P(space ~ "\"" ~/ (strChars | escape).rep.! ~ "\"").map(JString.apply)
[error]                                           ^
[error] one error found

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johnynek any concerns about this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concern for bench.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Compile / unmanagedSources := {
if (Set("2.12", "2.13").contains(scalaBinaryVersion.value)) {
(Compile / unmanagedSources).value
Expand Down
2 changes: 1 addition & 1 deletion project/Dependencies.scala
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ object Dependencies {
lazy val cats211 = Def.setting("org.typelevel" %%% "cats-core" % "2.0.0")
lazy val munit = Def.setting("org.scalameta" %%% "munit" % "1.0.0-M10")
lazy val munitScalacheck = Def.setting("org.scalameta" %%% "munit-scalacheck" % "1.0.0-M10")
lazy val fastParse = "com.lihaoyi" %% "fastparse" % "2.3.3"
lazy val fastParse = "com.lihaoyi" %% "fastparse" % "3.0.2"
lazy val parsley = "org.http4s" %% "parsley" % "1.5.0-M3"
lazy val jawnAst = Def.setting("org.typelevel" %% "jawn-ast" % "1.5.1")
lazy val jawnAst211 = Def.setting("org.typelevel" %% "jawn-ast" % "1.0.0-RC2")
Expand Down