Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastparse to 3.0.2 #519

Merged
merged 9 commits into from Mar 20, 2024
Merged

Update fastparse to 3.0.2 #519

merged 9 commits into from Mar 20, 2024

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates com.lihaoyi:fastparse from 2.3.3 to 3.0.2 ⚠

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "fastparse" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lihaoyi", artifactId = "fastparse" }
}]
labels: library-update, early-semver-major, semver-spec-major, commit-count:1

@@ -121,6 +121,7 @@ lazy val bench = project
.settings(
name := "bench",
coverageEnabled := false,
scalacOptions += "-Wconf:cat=unused-nowarn:s",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suppresses this only for bench project

 [error] /home/runner/work/cats-parse/cats-parse/bench/src/main/scala/cats/parse/bench/fastparse.scala:50:43: @nowarn annotation does not suppress any warnings
[error]     P(space ~ "\"" ~/ (strChars | escape).rep.! ~ "\"").map(JString.apply)
[error]                                           ^
[error] one error found

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johnynek any concerns about this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concern for bench.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.06%. Comparing base (a070b3a) to head (f7d6d36).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   95.13%   95.06%   -0.07%     
==========================================
  Files          10       10              
  Lines        1480     1480              
  Branches      330      330              
==========================================
- Hits         1408     1407       -1     
- Misses         72       73       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@johnynek johnynek merged commit 1e64b32 into main Mar 20, 2024
14 checks passed
@johnynek johnynek deleted the update/fastparse-3.0.2 branch March 20, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants