[MB-8798] Fix deprecation warning for progress callback in pdf getDocument method #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
duncan-truss
requested review from
Ryan-Koch,
donaldthai,
hannaliebl,
jenniferlynparsons and
monfresh
Ryan-Koch
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading pdf documents in the file viewer, we would see a warning message about using the progress callback in the
getDocumentmethod in the browser console.The recommended fix is to no longer pass in a progress callback method to that function but to define the
onProgressfunction property on the returned loading task promise.To test the new fix you should be able to run
yarn startand visitlocalhost:8081from this repository. The sample pdf displayed is quite small and the loading happens really fast so it's difficult to test the loading indicator even for a larger file loaded from local disk. I did log out the calls to set state to confirm it's still being updated, it may be easier to test integrated as the MilMove document viewer or with a network file.Please also review the PR in the mymove repo that uses this updated branch transcom/mymove#7036