New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MB-8798] Fix deprecation warning for pdf files in the document viewer progress callback #7036
Merged
duncan-truss
merged 4 commits into
master
from
ds-mb-8798-react-file-viewer-update-fix-deprecation-msg
Jul 23, 2021
Merged
[MB-8798] Fix deprecation warning for pdf files in the document viewer progress callback #7036
duncan-truss
merged 4 commits into
master
from
ds-mb-8798-react-file-viewer-update-fix-deprecation-msg
Jul 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle difference
|
duncan-truss
requested review from
donaldthai,
hannaliebl,
jenniferlynparsons,
monfresh,
Ryan-Koch and
a team
July 21, 2021 15:29
Ryan-Koch
approved these changes
Jul 22, 2021
monfresh
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described. Thanks!
Bundle difference
|
Bundle difference
|
Bundle difference
|
duncan-truss
deleted the
ds-mb-8798-react-file-viewer-update-fix-deprecation-msg
branch
July 23, 2021 13:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our document viewer library
react-file-viewer
fork to use changes to no longer use the deprecated getDocument function with the progress loading callback trussworks/react-file-viewer#5. This only applies the loading of PDF files in the orders or payment requests document viewer so make sure you are looking at uploads that are not images.When that PR gets merged into master I will update the package.json to no longer resolve to using the branch name.
It looks like we're still seeing another warning about an undefined function but we will need to upgrade pdf.js to eventually get rid of this mozilla/pdf.js#3768
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
Add any steps or code to run in this section to help others prepare to run your code:
AMDORD
http://officelocal:3000/moves/AMDORD/ordersoption + command + i
or from the Tools -> Browser Tools -> Web Developer Tools menu in Firefox.Code Review Verification Steps
References
Screenshots