Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: experimenting with standalone React-client #5498

Open
wants to merge 26 commits into
base: next
Choose a base branch
from
Open

Conversation

KATT
Copy link
Member

@KATT KATT commented Feb 19, 2024

Closes #

🎯 Changes

  • Experimenting if adding TRPCLinks to a tRPC client can affect the extra arguments we pass to e.g. trpc.post.by.id.query()
  • Experimenting with a standalone client

βœ… Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@KATT KATT requested a review from a team as a code owner February 19, 2024 08:03
Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
next-prisma-starter βœ… Ready (Inspect) Visit Preview Mar 3, 2024 0:55am
og-image βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 3, 2024 0:55am
trpc-next-app-dir ❌ Failed (Inspect) Mar 3, 2024 0:55am
www βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 3, 2024 0:55am

Copy link

github-actions bot commented Feb 19, 2024

Diagnostics Comparison

Numbers

Metric PR next
Files 775 774 (πŸ”Ί 1)
Lines of Library 40,241 40,241 (βž– 0)
Lines of Definitions 117,205 117,161 (πŸ”Ί 44)
Lines of TypeScript 4,967 4,967 (βž– 0)
Lines of JavaScript 0 0 (βž– 0)
Lines of JSON 0 0 (βž– 0)
Lines of Other 0 0 (βž– 0)
Identifiers 173,593 173,320 (πŸ”Ί 273)
Symbols 107,838 107,712 (πŸ”Ί 126)
Types 89 89 (βž– 0)
Instantiations 0 0 (βž– 0)
Memory used 169,367 168,438 (πŸ”Ί 929)
Assignability cache size 0 0 (βž– 0)
Identity cache size 0 0 (βž– 0)
Subtype cache size 0 0 (βž– 0)
Strict subtype cache size 0 0 (βž– 0)

Timings and averages

Metric PR next
max (s) 4.162 4.225 (πŸ”½πŸŸ’ -0.06)
min (s) 4.162 4.225 (πŸ”½πŸŸ’ -0.06)
avg (s) 4.162 4.225 (πŸ”½πŸŸ’ -0.06)
median (s) 4.162 4.225 (πŸ”½πŸŸ’ -0.06)
length 1 1 (βž– 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.04 0.05 (πŸ”½πŸŸ’ -0.01)
Parse time 0.69 0.72 (πŸ”½πŸŸ’ -0.03)
ResolveTypeReference time 0.03 0.03 (βž– 0)
ResolveModule time 0.1 0.11 (πŸ”½πŸŸ’ -0.01)
ResolveLibrary time 0.02 0.02 (βž– 0)
Program time 1 1.07 (πŸ”½πŸŸ’ -0.07)
Bind time 0.41 0.42 (πŸ”½πŸŸ’ -0.01)
Total time 1.41 1.49 (πŸ”½πŸŸ’ -0.08)

@KATT KATT changed the title chore: experimenting chore: experimenting with standalone React-client Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant