Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): chained .pipe() in observables #5533

Merged
merged 9 commits into from Mar 3, 2024
Merged

fix(server): chained .pipe() in observables #5533

merged 9 commits into from Mar 3, 2024

Conversation

KATT
Copy link
Member

@KATT KATT commented Mar 2, 2024

Closes #

🎯 Changes

I haven't had to touch the observables in years as our use-cases are quite limited, but I noticed the other day that .pipe().pipe() was broken when working on #5498.

This fixes that... and now the operators look a bit more like the RxJs ones (e.g. https://github.com/ReactiveX/rxjs/blob/master/packages/rxjs/src/internal/operators/tap.ts)

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ✅ Ready (Inspect) Visit Preview Mar 3, 2024 10:59am
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 10:59am
trpc-next-app-dir ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 10:59am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 10:59am

Copy link

github-actions bot commented Mar 2, 2024

Diagnostics Comparison

Numbers

Metric PR next
Files 774 774 (➖ 0)
Lines of Library 40,241 40,241 (➖ 0)
Lines of Definitions 117,161 117,161 (➖ 0)
Lines of TypeScript 4,967 4,967 (➖ 0)
Lines of JavaScript 0 0 (➖ 0)
Lines of JSON 0 0 (➖ 0)
Lines of Other 0 0 (➖ 0)
Identifiers 173,320 173,320 (➖ 0)
Symbols 107,712 107,712 (➖ 0)
Types 89 89 (➖ 0)
Instantiations 0 0 (➖ 0)
Memory used 168,356 168,173 (🔺 183)
Assignability cache size 0 0 (➖ 0)
Identity cache size 0 0 (➖ 0)
Subtype cache size 0 0 (➖ 0)
Strict subtype cache size 0 0 (➖ 0)

Timings and averages

Metric PR next
max (s) 4.189 4.211 (🔽🟢 -0.02)
min (s) 4.189 4.211 (🔽🟢 -0.02)
avg (s) 4.189 4.211 (🔽🟢 -0.02)
median (s) 4.189 4.211 (🔽🟢 -0.02)
length 1 1 (➖ 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.05 0.04 (🔺 0.01)
Parse time 0.71 0.7 (🔺 0.01)
ResolveTypeReference time 0.03 0.03 (➖ 0)
ResolveModule time 0.1 0.11 (🔽🟢 -0.01)
ResolveLibrary time 0.02 0.02 (➖ 0)
Program time 1.04 1.03 (🔺 0.01)
Bind time 0.42 0.4 (🔺 0.02)
Total time 1.46 1.43 (🔺 0.03)

@KATT KATT changed the title 03 03 pipe pipe fix(client / server): fix multiple chained .pipe()-operators Mar 3, 2024
@KATT KATT marked this pull request as ready for review March 3, 2024 00:24
@KATT KATT requested a review from a team as a code owner March 3, 2024 00:24
@KATT KATT changed the title fix(client / server): fix multiple chained .pipe()-operators fix(client / server): chained .pipe() in observables Mar 3, 2024
trpc-bot
trpc-bot previously approved these changes Mar 3, 2024
Copy link

github-actions bot commented Mar 4, 2024

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants