-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tap to confirm animation for mercury UI #3805
Open
TychoVrahe
wants to merge
1
commit into
tychovrahe/ui-t3t1/htc-anim
Choose a base branch
from
tychovrahe/ui-t3t1/confirm_action
base: tychovrahe/ui-t3t1/htc-anim
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
tap to confirm animation for mercury UI #3805
TychoVrahe
wants to merge
1
commit into
tychovrahe/ui-t3t1/htc-anim
from
tychovrahe/ui-t3t1/confirm_action
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/confirm_action
branch
from
May 8, 2024 13:44
b7f5d8a
to
a137bbc
Compare
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/confirm_action
branch
from
May 19, 2024 12:47
3522247
to
0fd6768
Compare
TychoVrahe
changed the title
tap to confirm, confirm action for mercury UI
tap to confirmanimation for mercury UI
May 19, 2024
|
TychoVrahe
changed the title
tap to confirmanimation for mercury UI
tap to confirm animation for mercury UI
May 21, 2024
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/confirm_action
branch
from
May 21, 2024 11:57
0fd6768
to
9152ab3
Compare
TychoVrahe
removed
the
blocked
Blocked by external force. Third party inputs required.
label
May 21, 2024
obrusvit
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
core/embed/rust/src/ui/model_mercury/component/prompt_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/model_mercury/component/hold_to_confirm.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/model_mercury/component/prompt_screen.rs
Outdated
Show resolved
Hide resolved
obrusvit
approved these changes
May 21, 2024
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/htc-anim
branch
from
May 24, 2024 12:59
2fbe4a0
to
38c6b52
Compare
[no changelog]
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/confirm_action
branch
from
May 24, 2024 13:02
943eba2
to
098c131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements tap-to-confirm animation for mercury UI.