-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T3T1 mercury UI - PIN keyboard and flow #3814
Conversation
|
|
Tested on device and it works nicely 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please regenerate fixtures.json (ones that don't fail) and also make sure all screens of the multi-screen flows are covered by device tests. The current copypaste from Model T records only the first screen - this doesn't need to be changed everywhere but the new screens need to be recorded in at least one test case.
Please change the X/delete/check buttons according to figma. |
9e66f09
to
593a2aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge this if the button issue is addressed
[no changelog]
[no changelog]
Adds SwipeFlow for ConfirmAction or ConfirmActionSimple. Without animation as of now. [no changelog]
593a2aa
to
a6ef698
Compare
rebased, I will wait for CI to update fixtures, then merge |
[no changelog]
a6ef698
to
b1261fc
Compare
QA OK Info:
|
PR adds:
confirm_action
taken from tap to confirm animation for mercury UI #3805 and modified slightly so that we can confirm also actions without explicit "tap to confirm" or "hold to confirm" but only with simple "swipe up"Some limitations added here for now #3748