-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add brightness setting #3791
base: ui-t3t1
Are you sure you want to change the base?
add brightness setting #3791
Conversation
|
9984a15
to
cabdf90
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two high level comments (also mentioned in the review):
(a) perhaps there should be a SetBrightness
call as opposed to shoving it into settings? depends on whether we ever want the user to set brightness from host
(if we do, the handling for that is completely missing)
(b) I would avoid exposing to Python. I can take over that part if you like
@TychoVrahe please check my changes |
2acd186
to
9d0deeb
Compare
core/embed/rust/build.rs
Outdated
let default_macros = DEFAULT_BINDGEN_MACROS_COMMON | ||
.iter() | ||
.chain(DEFAULT_BINDGEN_MACROS_T2T1) | ||
.chain(DEFAULT_BINDGEN_MACROS_T2B1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we miss also T3T1
specifics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, this is a cherrypick of cf58fdd from main. we probably should, but this commit should be removed from the PR before merging, and someone should add T3T1 features when merging the UI branch into main (or later, whenever we hit a problem caused by it, so probably when you try to run T3T1 Rust tests)
Cancelled, | ||
} | ||
|
||
pub struct NumberInputSliderDialog { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: copy of model_t
version. Should be reworked for mercury
when design done.
Linking it here for now: #3748
ce29822
to
1f52422
Compare
4f76aea
to
fdeaf19
Compare
fdeaf19
to
d57d281
Compare
building on #3483, but adding support for
mercury