Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tap to confirm animation for mercury UI #3805

Open
wants to merge 1 commit into
base: tychovrahe/ui-t3t1/htc-anim
Choose a base branch
from
Open

tap to confirm animation for mercury UI #3805

wants to merge 1 commit into from

Conversation

TychoVrahe
Copy link
Contributor

@TychoVrahe TychoVrahe commented May 8, 2024 •
edited

Implements tap-to-confirm animation for mercury UI.

@TychoVrahe TychoVrahe self-assigned this May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 3280 test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/confirm_action branch from b7f5d8a to a137bbc Compare May 8, 2024 13:44
@TychoVrahe TychoVrahe linked an issue May 8, 2024 that may be closed by this pull request
T3T1 tap to confirm animation #3789
Open
@Hannsek Hannsek added the blocked Blocked by external force. Third party inputs required. label May 9, 2024
@Hannsek Hannsek requested a review from obrusvit May 9, 2024 10:16
@obrusvit obrusvit mentioned this pull request May 9, 2024
Merged
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/confirm_action branch from 3522247 to 0fd6768 Compare May 19, 2024 12:47
@TychoVrahe TychoVrahe changed the title tap to confirm, confirm action for mercury UI tap to confirmanimation for mercury UI May 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 19, 2024 •
edited

legacy UI changes device test(screens) main(screens)

@TychoVrahe TychoVrahe changed the title tap to confirmanimation for mercury UI tap to confirm animation for mercury UI May 21, 2024
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/confirm_action branch from 0fd6768 to 9152ab3 Compare May 21, 2024 11:57
@TychoVrahe TychoVrahe removed the blocked Blocked by external force. Third party inputs required. label May 21, 2024
@TychoVrahe TychoVrahe changed the base branch from ui-t3t1 to tychovrahe/ui-t3t1/htc-anim May 21, 2024 11:58
@TychoVrahe TychoVrahe marked this pull request as ready for review May 21, 2024 11:58
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner May 21, 2024 11:58
@TychoVrahe TychoVrahe removed the request for review from prusnak May 21, 2024 11:58
@mmilata mmilata added the T3T1 label May 21, 2024
obrusvit
obrusvit reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

core/embed/rust/src/ui/model_mercury/component/prompt_screen.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/model_mercury/component/hold_to_confirm.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/model_mercury/component/prompt_screen.rs Outdated Show resolved Hide resolved
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/htc-anim branch from 2fbe4a0 to 38c6b52 Compare May 24, 2024 12:59
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/confirm_action branch from 943eba2 to 098c131 Compare May 24, 2024 13:02
@andrewkozlik andrewkozlik removed their request for review May 24, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit obrusvit approved these changes

@matejcik matejcik Awaiting requested review from matejcik

Assignees

@TychoVrahe TychoVrahe

Labels
T3T1
Projects
Firmware
Status: 🔎 Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

T3T1 tap to confirm animation
4 participants
@TychoVrahe @obrusvit @mmilata @Hannsek