-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui: fixed width for speed info #6739
Conversation
CC @tessus, see what you think of this. |
I am sorry, but I don't like it. It makes me nervous just by looking at it. But we'll never agree on this I am afraid. It's just a personal preference. Apart from that it looks a bit unprofessional. Imagine I really appreciate you trying to find a compromise though. |
b7faed9
to
ff892e4
Compare
Well, that's a shame. I think this is a step closer to agreement though. If others agree, then I think this should be merged. |
Absolutely an improvement. Less movement = less distractions. A definite merge for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a step closer to agreement though.
Yep, this is an improvement, and anybody can reiterate a better-looking solution later.
Even if it is not consitent, is that a problem if the users doesn't get bothered by it? Edit: Just saw your suggestion of moving the arrows to the right. I'll make a screen recording of that, then we can see how it looks like. Edit 2: @Coeur I think this is completely fine, wdyt? |
What bothers me is that the up arrow is closer to the download speed text than the upload speed text most of the time. I get it that you can still tell which is which by their order of appearance, but I don't want to replace a flaw with another flaw.
The data is not moving around in my implementation though...? Just the up/down arrows are moving. I've also just posted another alternative that puts the arrow to the right of the text, so nothing moves now. |
Now this is something I can agree with. 👍 🎉 ❤️ |
Just committed the change to move arrows to the right. |
58d0089
to
3191033
Compare
Not sure how I feel about this. It doesn't change that often to cause for distraction. It's short string that takes 5 seconds to refresh, the chance of digits changing is 1 out of 10, so gaps is more of a distraction :) I MAY be ok with arrows switched to another side for less movements required to them. Just something I noticed, I love your attractive screenshots showcasing your fixes, but the localization differences are providing different people between "s" and "sec", it can cause issue for those with "sec" and width appearing too wide for those with "s". Please port the fix from the main branch for 4.0.x that has the issue, instead of creating another fix with preferences that will not be satisfied by everyone. |
I am not sure who you are addressing. I am using I am not doing anything to my PR for the 4.0.x branch. My fix has been there for months. I stopped looking at whether it's been merged and I don't care anymore. This project seems a bit weird with merging, release cadence, ... |
@Rukario Do you have a better feel for how this should be done now?
I wonder if there is anything we can do about this that is pure CSS... I am reluctant to use JavaScript for this, makes the styling code harder to trace. Suggestions? |
@tearfur The unit is "s" so localizations that use "sec" or anything else should be replaced. In Shift I put the Unicode arrows next to each other in the title bar: Also the jumping around of the speed indication numbers is less of an issue when the update interval is longer than a couple of seconds. |
Our code is: transmission/web/src/formatter.js Lines 44 to 53 in 0e25584
So when it displays
That's nice too. But I'd prefer to stick with current approach in present PR for now.
I'd prefer to stick to 1 second refresh for a unit which is in extenso "per second". |
Not a bug, but an inconsistency. Why only use the "short" version of part of the unit? So it should either be "kB/s" or "kilobyte/second". But I guess "narrow" would be a good start for some experimentation because I can't find what that specifies exactly. (Vendor specific maybe?) |
Thank you tessus. I reproduced the |
Hmm, I wouldn't know why Canadian locale should be different in that regard. We use Sunday as the start of the week (which makes no sense unless you are in the Middle East), we use the 12h and the 24h clock, and we use way too many date formats. There is no proper standard in Canada for date and time. Which is why I always set them to YYYY-MM-DD/24h/Monday no matter which locale or region I set. In my terminal on macOS my locale is So now I tried setting the Region to United States and Safari shows xx/s. Which makes this even weirder because my Firefox browser actually uses the US locale, but still shows xx/sec, unless I change it in the System Settings of macOS. I have always found localization extremely annoying. Why the heck does the world not use unambigious formats and be done with it. Anyway, I gave up on trying to understand or discuss this. I just don't care anymore and I have accepted for many years now that IT failed in this area big time and that this will never truly be fixed - ever. |
@tessus That is what the ISO formats are for. Some insight for (at least) American readers here: The Metric Maven |
Hahaha. I haven't laughed that much and hard in a while. Thank you for that. Yes, I know that ISO is supposed to solve the ambiguity issue. But products in Canada use e.g. the following formats for expiry date: MM/YY YY/MM DD/MM/YY YY/DD/MM MM/DD/YY and whatnot. if you are lucky they use MMM. Anyway, nobody gives a damn about ISO. I've been in IT for over 30 years. SW uses all kinds of formats, and if you are lucky the format is explained in some docs - but mostly it is not. I lived and spent time in many parts of the world, Canada is not the exception, when it comes to ignorance of ISO. Unless ISO is used worldwide without exception, it is useless. I use ISO (or close to ISO w/o ambiguity), but that's just me. All companies I worked for ignored my plea to use ISO. states/provinces in North America can't even get rid of this idiotic daylight savings time. Same shit is happening in Europe. They've been talking for years and years. What happened? Nothing. Anyway, my rant is way off-topic and I stop here. But thanks for the laugh. It was refreshing. |
Looks like those voting in favor of this outnumber those voting against, so let's merge this. |
Implement my suggestion at #6577 (comment).
Fix the width of the upload speed info, so that the download speed info will not move around in response to upload speed changes.
Edit: Moved the arrows to the right of the text as suggested by #6739 (comment).
previous iteration