-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improved filterbar for narrowed viewports in web client #6761
Conversation
@Pentaphon Ideally this PR jointed with a 4.0.x port of #6739 that would change the layout to however we want for the 4.0.x release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor branch shear w / web/assets/css/transmission-app.scss
Oh, it looks like another PR (#6570) was merged that isn't complied with narrowed viewport this PR tried to resolve. What should I do from this point? |
@tearfur wdyt? |
I think this PR should overwrite the changes made in #6570. Maybe we can just revert it, then the git conflict will be gone. We reached a consensus in #6739 over the solution for stopping the transfer speed info from moving around as the text changes, and that requires merging this PR, then porting #6739 to |
@Rukario ^ |
Ok, overwrote changes made in another PR Have we really reached consensus for fixed width though? |
Well, IMO the bottom line is regardless of how the "fixed width" discussion develops, this PR should be merged. |
@Rukario this has a little bit of shear with your original PR -- you removed the width property for speed-dn-label and speed-up-label, and there's also #6570 which widened it to 100px and set I've preserved 6570 here but TBH I'm not sure if it's still needed with your other changes, so please feel free to LMK or fix my meddling in a followup PR ❤️ |
I thought a overwrite would have done the job? Maybe I don't understand GitHub too well. This PR is a direct backport of another PR with a fix that has been merged into master branch. This PR and #6570 fix the same issue but doesn't need both, that would make this PR a compromised port. |
Features and fixes ported from #5828 for 4.0.x release
Resolves #6375
Notes: General UI improvement related to filterbar and fixes download/upload speed info wrap.
Left: This PR, Right: Original