New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Bittorrent v2 (bep 0052) #458
Comments
libtorrent announced BEP-0052 / BitTorrent v2 support today. |
Transmission fails to open torrent files encoded with the v2 reference implementation that contain v1 and v2 data. The libtorrent blog post suggests this torrent should have been compatible with older clients. It works in a lot of other clients. The error message says “invalid or corrupt torrent file.” |
SHA-1 chosen-prefix attacks are now in the USD 10k-100k range. This presents a very real threat, for example against bittorrent-distributed software that might be used by dissidents or whistleblowers. BitTorrent v2 should be high priority now. |
BitErrant could be used to initially seed a benign payload, then later switch to a malicious payload. You could either selectively deliver the malicious payload only to chosen targets, or just start delivering it to everyone after some time. |
Any updates to this? Can we expect it this year? |
At least it should be fixed |
It would be nice to see this feature implimented, if not for massive levels of current usage then for futureproofing. |
#2542 implements part of this by adding support for reading Bittorrent v2 |
Any news on this? We need v2 reading support asap. Transmission can't open any torrent created by qBittorrent. |
Yeah, at least compatibility with hybrid torrents is crucial. Full v2 support can come later but right now transmission just can't open files. |
I recompiled from current master (70fbce7) and hybrid files can be opened, thanks. |
No, only hybrid torrents that contain v1 and v2 information work on the master branch right now. Transmission will parse the v1 data and will ignore v2 data. |
I do not understand why this feature does not have a high priority. In my experience, current half of the torrent is not able to read the transmission. |
Yeah I am moving away from Transmission because of this missing feature. It's a shame because qBittorrent's CLI and web UI are much worse, and the client runs slower than Transmission on my underpowered seedbox, but there have been several torrents in the last few months that I was simply unable to download with Transmission. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as off-topic.
This comment was marked as off-topic.
@Zipdox testing with what Transmission build? If you're still seeing this in a recent build, can you create a hybrid torrent with public domain contents and attach it to this ticket? No need to seed it; I just want to figure out what's not parsing. |
Is there any bypass for magnet links to work with Transmission? We are trying to enable BitTorrent v2 support in our torrent tracker, but since Transmission clients having problems we got our hands tied. |
@kovalensky depends on what you're asking for: BitTorrent v2 has the concept of hybrid torrents, where the torrent file & magnet links can have both the sha1 and sha256 info hash. Transmission 4, which is in beta now, supports v2 hybrid torrents and their magnet links. But Transmission 4 still needs that sha1 hash, so a torrent that is only v2 (i.e. not a hybrid) won't work in Transmission until 5. |
We enabled Bittorrent v2 support (15k users) base, but 30% of our good seeding users using Transmission version lesser than 4. |
Sounds like the solution is to just get 4.0.0 stable out the door |
Looks related to #3386. Very frustrating. |
In 2023 there is no need for hybrid (using v1 and ignoring v2). V2 only will be enough. Stable 3.0 is in repos of many distros now. Will it be implemented in upcoming 4.0? Why you mark it like "feature"? Client can't open torrent files, it is must urgent Bug! :( |
@s777s This kind of tone and approach always wears away at the developers. Please try to be nicer next time despite your frustration 👍 |
@s777s While I too would appreciate v2 support, it's very frivolous to call it a bug. It is not. To make any software support something, somebody must implement it. I'm sure there's quite a lot of work involved in implementing v2 torrents. So, it all comes down to who has the knowledge, will and opportunity to implement it. I very much doubt labeling something a "bug" and going on a little tantrum will help motivate anybody to find the time and invest the effort needed. |
There are a couple of different related / overlapping questions here that I want to answer:
For everyone who wants these changes to come sooner -- requests are welcomed. That's serious, not snark. The maintainers, including me, have made it a priority to do PR review and help contributors the PRs past the finish line. |
@ckerr to be honest, I appreciate your work and using your client for many years, so I want to say sorry for my tone and thank you for your work. Was a little irritated, because on some trackers there are some seeds (not all) with incompatible newer version. And was a little surprised to see words "vulnerability", "2017" and "feature" in the top of the thread while was googling why torrent file doesn't work. |
So, either I'm very confused here, or I guess should file this as a documentation bug. The first entry in the 4.0.0 release's New Features changelog section is
But this issue seems to be suggesting that it just supports "not breaking", and can't actually use v2 torrents? That seems highly misleading, to the point where I'm not actually sure what the software can do. |
EDIT: Nevermind, it appears I am entirely wrong on this, and it is unrelated to V1/V2. Per another member on the tracker:
I will try to track down more information on this and put it into the relevant discussion/issue thread. |
Should this still be open now that v4.0.0 (and later) is out? It seems like the only piece missing is the ability to create v2 torrents. Edit: I tried using the v2 only magnet link and .torrent file provided here, with Transmission 4.0.5: https://blog.libtorrent.org/2020/09/bittorrent-v2/ The magnet one gave an error, and the v2 only torrent file didn't throw an error, but didn't add the torrent. I'm not quite sure how v2 is supposed to be working with Transmission v4. |
Yes, no support yet with the example of https://blog.libtorrent.org/2020/09/bittorrent-v2/ |
By the way, I compiled Transmission from Git (4.1.0-dev (1855cdb)) successfully on my Monterey 12.6. Bravo! Support for V2 is not here yet. May be it could be added on the Readme.md that there is no support yet because you can google people having run V2 successfully with version 4.0! |
I haven't seen any info on whether there's any effort in transmission to support the bittorrent v2 format [1].
Are there any plans or efforts to support it yet? The major reason is the breakage of SHA1, which causes vulnerabilities like the BitErrant attack [2]. The v2 format switches to SHA256 and a Merkle tree structure.
As long as this is unfixed torrents can't be considered as a secure download method that guarantee data integrity.
[1] http://www.bittorrent.org/beps/bep_0052.html
[2] https://biterrant.io/
The text was updated successfully, but these errors were encountered: