Add basic support for v2 hashes in transmission-show #3380
Conversation
|
I love this; it's progress on a milestone that's important to the project and I really appreciate the added tests! But it's going to FTBFS on any non-openssl platform in the current form, e.g. when building on macos or with polar or cyassl. @Lanzaa are you interested in doing any work on that? Even if you don't have access to the platforms, You can get build logs from the "Sanity (Transmission) - TeamCIty" links in the Checks section above |
|
Ok, I've got a basic update with the other crypto libraries and added a test case which will verify the very basics of sha256 support. Hopefully it all works, I did the change blind w/o a build environment for them. I don't really want to spend much time on this portion. |
If you have any questions or need anything, feel free to open new issues / discussions and assign me or @ me. I love that you're doing this. |
* Fix issue with sha256 digest length
* Add sha256 for polarssl
Note: Bumping miniumum PolarSSL version to 1.3 because of
sha2->sha256 name change.
* Add sha256 for CommonCrypto/ccrypto
* Add sha256 for cyassl
test: add tr_sha256_to_string to mangling keep banging my head against CI until it works
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Looks like 23e2390 might've finally gotten it right, but one of the CI boxes is offline so this will probably need to wait until sometime tomorrow when we can get CI green again. 😐 |
|
OK, that one runner's been down for a day and a half now and the other runs were all green. I think it's OK to go ahead with this. |
Relates to issue #458 and BEP-0052 (bittorrent v2).
Included in this patch is support for calculating a v2 info hash from a torrent file.
I am hoping for comments as I continue to work on further v2 support. I have not done much C++ programming in a while, so suggestions for improvement are very welcome.