New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix background colors margin + fix dark mode #253
base: main
Are you sure you want to change the base?
Fix background colors margin + fix dark mode #253
Conversation
@Vadorequest is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
@@ -308,7 +338,7 @@ | |||
padding: 0; | |||
margin: 0; | |||
border-radius: 0; | |||
background: none !important; | |||
background-image: none !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is intentional for my site. i don't really like how the highlight colors look in dark mode, so i decided to just disable them entirely.
happy to take suggestions on how to make things look better tho :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The colors are more of a custom design that I took from some design blog awhile back. They're not supposed to be notion-specific. I could definitely see this being confusing for people, though, since it's clearly surprising. This may be one of those things that I customize for my branch and leave the notion defaults for the main branch. Let me noodle on it a bit. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/saasify/transitivebullshit/AgyYn46ZcTuo26LEcom8jmrvpmpf |
https://ambroise-dhenain.vercel.app/about (WIP, started playing with it only yesterday, lots of copycat)
Before, backgrounds were entirely disabled in dark mode.