Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background colors margin + fix dark mode #253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vadorequest
Copy link
Contributor

@Vadorequest Vadorequest commented Apr 3, 2022

https://ambroise-dhenain.vercel.app/about (WIP, started playing with it only yesterday, lots of copycat)

  • The margin fix is probably an old typo mistake
  • 119 > 90 deg, makes it take less space (left/right), but might go against what you intended
  • I used the same colors as in feat: make the bg color more 'notion' #201, noticed that PR after creating my own

Before, backgrounds were entirely disabled in dark mode.

@vercel
Copy link

vercel bot commented Apr 3, 2022

@Vadorequest is attempting to deploy a commit to the Saasify Team on Vercel.

A member of the Team first needs to authorize it.

@@ -308,7 +338,7 @@
padding: 0;
margin: 0;
border-radius: 0;
background: none !important;
background-image: none !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is intentional for my site. i don't really like how the highlight colors look in dark mode, so i decided to just disable them entirely.

happy to take suggestions on how to make things look better tho :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought it might be the reason. Here is a diff between how they lock in dark/light modes if it helps.

image
image

@transitive-bullshit
Copy link
Owner

The colors are more of a custom design that I took from some design blog awhile back. They're not supposed to be notion-specific.

I could definitely see this being confusing for people, though, since it's clearly surprising. This may be one of those things that I customize for my branch and leave the notion defaults for the main branch.

Let me noodle on it a bit.

@vercel
Copy link

vercel bot commented Apr 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saasify/transitivebullshit/AgyYn46ZcTuo26LEcom8jmrvpmpf
✅ Preview: https://transitivebullshit-git-fork-vadorequest-improve-6b096a-saasify.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants