Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make the bg color more 'notion' #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iNorthIsle
Copy link

The bg style of notion-text is not correct, exist some duplicate colors, example notion link:
https://www.notion.so/northisle/Text-Bg-Color-e85150a465f34a45b60ac4bc667ab869

before after
image image

@vercel
Copy link

vercel bot commented Dec 8, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @transitive-bullshit on Vercel.

@transitive-bullshit first needs to authorize it.

@transitive-bullshit
Copy link
Owner

Hey @iNorthIsle thanks for the PR 👋

I think I have the same feedback here as my comment on #253 (comment). tbh I'm not sure how to proceed since these colors weren't meant to match notion's.

Suggestions welcome.

@Vadorequest
Copy link
Contributor

Vadorequest commented Apr 6, 2022

Matching Notion's colors would be the expected default. Maybe a way to easily override them from config could help, or simply point out where to change them in the code, using css variables might help as well with a dedicated theme.css file or something similar.

I'm not sure how difficult it is to use Site config variable within CSS with the current setup.

@iNorthIsle
Copy link
Author

Matching Notion's colors would be the expected default. Maybe a way to easily override them from config could help, or simply point out where to change them in the code, using css variables might help as well with a dedicated theme.css file or something similar.

I'm not sure how difficult it is to use Site config variable within CSS with the current setup.

I agree with U, Matching notion's default colors will be less confusing, and it also can be overridden by the site.config.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants