2.x Fix skipped tests #2760
Merged
2.x Fix skipped tests #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I first wondered why the tests suddenly fail. But then I saw that the tests fail with the latest version of WP CLI, which was released a couple of hours ago: https://github.com/wp-cli/wp-cli/releases/tag/v2.8.0. I reran the tests for 2.x, and there they failed, too: https://github.com/timber/timber/actions/runs/5121366322/jobs/9244799025. @nlemoine Do you have an idea why that might cause the tests to fail? |
|
I've just scrolled past this notice in the advanced WordPress group. Could it be related? |
Closed
|
Let’s wait until tests start working again, and then this will be ready for review. |
Levdbas
approved these changes
Jul 24, 2023
|
I think we are good to go at merging this @gchtr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue
There were some skipped tests because there WordPress errors non-related to Timber.
Solution
This pull request checks whether these tests still cause errors.
Impact
None.
Usage Changes
None.
Considerations
None.
Testing
Yes.