Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x Fix tests #2763

Closed
wants to merge 3 commits into from
Closed

2.x Fix tests #2763

wants to merge 3 commits into from

Conversation

gchtr
Copy link
Member

@gchtr gchtr commented Jun 5, 2023

Issue

Tests seem to be broken after upgrade to WP CLI 2.8.

Solution

Use WP CLI 2.7 as advised in #2760 (comment).

Impact

Fixed tests.

Usage Changes

None.

Considerations

None.

Testing

Yes.

@gchtr gchtr added the 2.0 label Jun 5, 2023
@nlemoine
Copy link
Member

nlemoine commented Jun 5, 2023

This issue has been discussed here: wp-cli/wp-cli#5795

Maybe we can wait for the 2.8.1 fix which will be out pretty quickly I guess?

@nlemoine
Copy link
Member

nlemoine commented Jun 5, 2023

Actually, it's already out: https://github.com/wp-cli/wp-cli/releases/tag/v2.8.1 😄

@gchtr
Copy link
Member Author

gchtr commented Jun 5, 2023

@nlemoine Oh, thanks for the hint 😅. I’ll check if the update fixes the issue.

@gchtr
Copy link
Member Author

gchtr commented Jun 5, 2023

Yep, after the PHAR build is also available, the newest CLI version is downloaded and the tests run through. Closing this.

@gchtr gchtr closed this Jun 5, 2023
@gchtr gchtr deleted the 2.x-test-fix-wp-cli branch July 20, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants