New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): gradle 8 #14014
base: master
Are you sure you want to change the base?
chore(android): gradle 8 #14014
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,3 +14,4 @@ build/ | |
/kroll-apt/bin/ | ||
/local.properties | ||
/titanium/assets/Resources/ti.internal/build.properties | ||
/.idea/ |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,17 +6,17 @@ | |
*/ | ||
|
||
buildscript { | ||
ext.kotlin_version = '1.8.20' | ||
ext.kotlin_version = '1.9.23' | ||
|
||
repositories { | ||
google() | ||
mavenCentral() | ||
} | ||
dependencies { | ||
classpath 'com.android.tools.build:gradle:7.0.4' | ||
classpath 'com.google.gms:google-services:4.3.15' | ||
classpath 'com.android.tools.build:gradle:8.3.1' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this the newest Gradle version we can upgrade to? I see 8.3 is over 8 months and 8.7 dropped about a month ago. |
||
classpath 'com.google.gms:google-services:4.4.1' | ||
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" | ||
classpath 'org.codehaus.groovy:groovy-json:3.0.11' | ||
classpath 'org.codehaus.groovy:groovy-json:3.0.17' | ||
} | ||
} | ||
|
||
|
@@ -30,7 +30,7 @@ allprojects { | |
project.apply plugin: 'checkstyle' | ||
checkstyle { | ||
toolVersion = '8.38' | ||
configFile file("${rootDir}/checkstyle.xml"); | ||
configFile file("${rootDir}/checkstyle.xml") | ||
ignoreFailures false | ||
showViolations true | ||
} | ||
|
@@ -39,6 +39,6 @@ allprojects { | |
project.apply from: "${rootDir}/templates/build/ti.constants.gradle" | ||
} | ||
|
||
task clean(type: Delete) { | ||
delete rootProject.buildDir | ||
tasks.register('clean', Delete) { | ||
delete buildDir | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
#Tue Mar 19 21:28:34 EET 2024 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip | ||
networkTimeout=10000 | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
org.appcelerator.kroll.annotations.generator.KrollJSONGenerator,dynamic |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,2 @@ | ||
rootProject.name = 'TitaniumSDK' | ||
include ':app' | ||
include ':kroll-apt' | ||
include ':titanium' | ||
include ':app', ':kroll-apt', ':titanium' |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -6,12 +6,13 @@ | |||||
*/ | ||||||
|
||||||
project.ext { | ||||||
tiAndroidXAppCompatLibVersion = '1.6.1' | ||||||
tiNdkVersion = '26.2.11394342' | ||||||
tiAndroidXAppCompatLibVersion = '1.4.1' | ||||||
tiAndroidXCoreLibVersion = '1.9.0' | ||||||
tiAndroidXFragmentLibVersion = '1.5.7' | ||||||
tiMaterialLibVersion = '1.6.1' | ||||||
tiPlayServicesBaseLibVersion = '18.2.0' | ||||||
tiManifestPlaceholders = [ | ||||||
tiActivityConfigChanges: 'density|fontScale|keyboard|keyboardHidden|layoutDirection|locale|mcc|mnc|navigation|orientation|screenLayout|screenSize|smallestScreenSize|touchscreen|uiMode' | ||||||
tiActivityConfigChanges: 'density|fontScale|keyboard|keyboardHidden|layoutDirection|locale|mcc|mnc|navigation|orientation|screenLayout|screenSize|smallestScreenSize|touchscreen|uiMode' | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Intentional indention?
Suggested change
|
||||||
] | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these indentations intentional?