chore(android): gradle 8 #14014
chore(android): gradle 8 #14014
Conversation
chore(android): fixed deprecations in kroll-apt project chore(android): made kroll-apt incremental to enhance build time
There was a problem hiding this comment.
Are the changes to the JAVA files necessary for the update? The more stuff that is changed, the more we have to test 😉
Also I wouldn't update the min and targetSDK with this PR. If we still can use 21 we should do that too. Same with target 34. I have a PR for that here #13940 as the broadcast receiver has to be adjusted.
So if that is not needed for the gradle PR please keep it as it is and do it in a separate PR (less changes, less testing).
I couldn't build a SDK locally. It's almost working but the last step titaniumPublication(MavenPublication) tries to publish it online instead of making a local repo? I've canceled it as it was uploading stuff 😄 Didn't want to publish something I don't need.
There aren't all cmake version available during build process. I have a different PR about that #13966 and I had to use 3.22.1 as that is available on all platforms.
fix(android): gradle 8 compatibility update to template build.gradle fix(android): revert dependency updates fix(android): revert minSdk and targetSdk
fix(android): update _build.js & _buildModule.js for new gradle
|
I have to do some testing but the first round was very good and I was able to build kitchensink an my app now 👍 Review will follow once I have more time to test |
chore(android): let there be gradle 8
chore(android): fixed deprecations in kroll-apt project
chore(android): made kroll-apt incremental to enhance build time
GitHub issue: #13579
This PR is dedicated to my mentor Nafe Abboushi.