Fix config typing and make Client easier to test #4711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client and ClientManager deal with both 'dehydrated' channels/networks (ie. directly from JSON configuration) and the 'rehydrated' ones (classes, with socket objects, message arrays, etc.). However, because their attributes are similar, both types were used interchangeably, which becomes an issue when splitting Client's configuration loading into smaller methods.
It will make it easier to write tests for what used to be in the connect() method
xPaw
reviewed
Mar 15, 2023
server/client.ts
Outdated
| @@ -96,7 +96,7 @@ class Client { | |||
| [socketId: string]: {token: string; openChannel: number}; | |||
| }; | |||
| config!: UserConfig & { | |||
| networks?: Network[]; | |||
| networks?: NetworkConfig[]; | |||
There was a problem hiding this comment.
Do you know why this networks isn't specified in UserConfig directly?
There was a problem hiding this comment.
I assume it's because it's optional in the attribute because of:
Lines 182 to 184 in efd24fd
but required as the constructor argument.
but I don't see the point of making it required. Fixed
xPaw
reviewed
Mar 15, 2023
MaxLeiter
approved these changes
Mar 15, 2023
|
Thank you! |
brunnre8
added
the
Meta: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing commits separately (and avoiding squash-merging), it should be easier to read