Fix load of channels from user config

[progval]

Network.export() only writes the "type" key if it's a ChanType.QUERY; so the config on disk has no "type":

thelounge/server/models/network.ts

Lines 633 to 639 in efd24fd

	if (chan.type === ChanType.CHANNEL) {
	keys.push("key");
	} else if (chan.type === ChanType.QUERY) {
	keys.push("type");
	}
	return _.pick(chan, keys);

This causes it to be undefined when loading, which breaks various other checks, and then drops it the next time the config is saved:

thelounge/server/models/network.ts

Lines 627 to 629 in efd24fd

	.filter(function (channel) {
	return channel.type === ChanType.CHANNEL || channel.type === ChanType.QUERY;
	})

[xPaw]

Can you add test coverage for this?

[progval]

I don't think I can do that without refactoring; it's in a the function that instantiates irc-framework

[xPaw]

Mhm yeah. I'm trying to think how this worked (before?) and when did it break.

[progval]

I just opened a PR with said refactoring: #4711

And merged #4711 into this PR along with a new test so you can see what it looks like.

[brunnre8]

Can you squash down the fixes? Then I'll merge it.
I'd do it on my own, but then GH is too stupid to let me "merge" it via some other commit and you'd loose the attribution here.

[progval]

done

[brunnre8]

Thank you val