New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /who handling #4547
base: master
Are you sure you want to change the base?
Add /who handling #4547
Conversation
52a0a87
to
bc1d6aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's no help material being added and there's no error messages we give back from the API (though maybe the server is doing some of that for us). Are you planning on doing another pass after this lands to add help text and error messages?
Though I'm also not sure I understand why support for /who
is being added.
I also added an uncaught exception handler on the server to stop a subset of crashes. The problem is people won't look at their server logs often, but bookworm and I agreed that's better than crashing.
I'll defer to you two. But TBH I'd prefer we continue to crash. I'd prefer failures make as much noise as possible especially with that huge TypeScript change looming.
irc-framework sends the WHOX cuhsnfdaor flags and doesn't support receiving others, so we manually remove parameters the user doesn't request. I also added an uncaught exception handler on the server to stop a subset of crashes. The problem is people won't look at their server logs often, but bookworm and I agreed that's better than crashing. When we add an admin role we can report it to them. https://ircv3.net/specs/extensions/whox ref kiwiirc/irc-framework#331
a: "account", | ||
r: "realname", | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, why are you doing it this way?
You are creating a mapping that's never used, plus a function to translate it to what you actually want.
Can't we just directly create the mapping we need from single char to field name of TL?
irc-framework sends the WHOX
cuhsnfdaor
flags and doesn't support receiving others, so we manually remove parameters the user doesn't request.I also added an uncaught exception handler on the server to stop a subset of crashes. The problem is people won't look at their server logs often, but bookworm and I agreed that's better than crashing. When we add an admin role we can report it to them.
https://ircv3.net/specs/extensions/whox
ref kiwiirc/irc-framework#331