Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove whois irc-event event handler, send whois/whowas response to current buffer #4548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove whois irc-event event handler, send whois/whowas response to current buffer #4548

wants to merge 1 commit into from

Conversation

MaxLeiter
Copy link
Member

@MaxLeiter MaxLeiter commented Apr 27, 2022 •
edited

We can remove the event handler now that we use the irc-framework callback similar to #4547

Closes #492

Updated to Typescript/vue 3

@MaxLeiter MaxLeiter added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Apr 27, 2022
@MaxLeiter MaxLeiter changed the title Remove whois irc-event listener, send whois response to current buffer Remove whois irc-event event handler, send whois response to current buffer Apr 27, 2022
@MaxLeiter MaxLeiter added the Status: needs-review PR not yet reviewed by enough maintainers label Apr 28, 2022
@MaxLeiter MaxLeiter changed the title Remove whois irc-event event handler, send whois response to current buffer Remove whois irc-event event handler, send whois/whowas response to current buffer Apr 28, 2022
@brunnre8
Copy link
Member

/whowas on a user without an entry doesn't send the message to the current channel, but to the server buffer and only in debug:

17:40 *** WHOWAS asdf
17:40 *** :copper.libera.chat 406 thisisatestthing asdf :There was no such nickname

@MaxLeiter MaxLeiter requested a review from brunnre8 April 29, 2022 19:21
@brunnre8
Copy link
Member

Considering that we always send the two value whois, there's no error reply when the nick is invalid, opened kiwiirc/irc-framework#334 so that we can then add a proper handler

@MaxLeiter MaxLeiter added Status: WIP Work in progress or feature not fully fleshed out yet and removed Status: needs-review PR not yet reviewed by enough maintainers labels Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunnre8 brunnre8 Awaiting requested review from brunnre8

Assignees
No one assigned
Labels
Status: WIP Work in progress or feature not fully fleshed out yet Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/whois nick should go to currently active window
2 participants
@MaxLeiter @brunnre8