Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix node 15 #809

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 27, 2020

What:

Explicitly add node 15 to the matrix and fix compat issues.

Why:

We declare that we support node >= 10 so we should test accordingly. Now that node 15 is released we can declare it in the matrix.

How:

Follow advise in npm/cli#1935 until npm fixes its CI detection.

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85bf40d:

Sandbox Source
React Configuration
kentcdodds/react-testing-library-examples Configuration

MatanBobi
MatanBobi previously approved these changes Oct 27, 2020
.travis.yml Outdated Show resolved Hide resolved
@eps1lon
Copy link
Member Author

eps1lon commented Oct 27, 2020

@kentcdodds Could you elaborate why we have the separate node identifier? As far as I can tell travis is not deduplicating the matrix so you end up with two runs for node 15 (before its release we had two runs for node 14): https://travis-ci.org/github/testing-library/react-testing-library/builds/739343261. It makes more sense to me to remove the node entry and update the config once node 16 is released.

node was added in ea67b17

@MatanBobi
Copy link
Member

@kentcdodds Could you elaborate why we have the separate node identifier? As far as I can tell travis is not deduplicating the matrix so you end up with two runs for node 15 (before its release we had two runs for node 14): https://travis-ci.org/github/testing-library/react-testing-library/builds/739343261. It makes more sense to me to remove the node entry and update the config once node 16 is released.

node was added in ea67b17

@eps1lon it looks like @kentcdodds wrote in #808 (comment) that we can remove the separate node identifier.. So I guess you can go ahead and remove it :)

@eps1lon eps1lon changed the title test: Run with node 15 test: Don't run with node 15 Oct 27, 2020
@nickmccurdy
Copy link
Member

I thought we still wanted to test Node 15, but using 15 instead of node so the version doesn't change over time

@eps1lon
Copy link
Member Author

eps1lon commented Oct 27, 2020

I can do this all day 😬

.travis.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #809 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #809   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          117       117           
  Branches        16        16           
=========================================
  Hits           117       117           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f54b5...85bf40d. Read the comment docs.

@eps1lon eps1lon marked this pull request as ready for review October 29, 2020 11:19
@nickmccurdy nickmccurdy changed the title test: Don't run with node 15 test: Fix node 15 Oct 29, 2020
@nickmccurdy
Copy link
Member

Looks ready to merge for me

@eps1lon eps1lon merged commit c2806fc into testing-library:master Oct 29, 2020
@eps1lon eps1lon deleted the build/fix-node-15 branch October 29, 2020 14:06
.travis.yml Show resolved Hide resolved
@testing-library-bot
Copy link

🎉 This PR is included in version 11.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants