build: allow node latest build to fail

[MatanBobi]

This is due to a braking change in npx adding a -y flag

What: Allow node latest build to fail because of a change in npx requiring us to add a -y flag to our CI.

Why: At the moment, our build is failing for Node 15.

How: Add the node latest version to the allow_failures section.

Checklist:

• Documentation added to the
  docs site - N/A
• Tests - N/A
• Typescript definitions updated - N/A
• Ready to be merged
  

This was raised in this comment by @kentcdodds.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f9379a5:

Sandbox	Source
React	Configuration
kentcdodds/react-testing-library-examples	Configuration

[eps1lon]

But now any failure in node would be displayed as green.

Does travis not allow conditional scripts based on variables? We should rather adjust the jobs accordingly i.e. run npx -y codecov@3 in node 15

Edit: just found

npm_config_yes=true npx mocha

-- npm/cli#1935 (comment)

[codecov]

Codecov Report

Merging #808 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #808   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          117       117           
  Branches        16        16           
=========================================
  Hits           117       117           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f54b5...f9379a5. Read the comment docs.

[MatanBobi]

But now any failure in node would be displayed as green.

Does travis not allow conditional scripts based on variables? We should rather adjust the jobs accordingly i.e. run npx -y codecov@3 in node 15

Edit: just found

npm_config_yes=true npx mocha

-- npm/cli#1935 (comment)

The allow_failures is only for node and not for the specific versions if I understood correctly as you can see here..

But I do agree that it would be better to fix it specifically for node 15. I'll have a look as I'm not 100% familiar with travis.

[eps1lon]

I'll have a look as I'm not 100% familiar with travis.

I would start with npm_config_yes=true npx mocha first. Seems like the easier choice.

[kentcdodds]

We could definitely go with that approach, but I'm not a big fan of experimental software (odd versions of node) blocking our ability to release 😬 If something else comes up that would be pretty annoying.

[eps1lon]

We could definitely go with that approach, but I'm not a big fan of experimental software (odd versions of node) blocking our ability to release If something else comes up that would be pretty annoying.

I'm hesitant as well but npm_config_yes=true npx -y codecov@3 looks not that invasive to me.

[kentcdodds]

I agree it's not a big deal. What I mean is considering Node 15 is experimental software, our build could break for confusing reasons and if that stops us from shipping that would be annoying since we technically don't support experimental versions of node.

[kentcdodds]

I guess I'm saying we can add that to get around this issue, but I also want to make it so the node 15 build doesn't fail CI.

[eps1lon]

Why do we have the node target in travis to begin with? We already list 14 and 16 is 6mo out. Would it make more sense to replace node with lts/*? Otherwise I don't understand what the point is to test on node 15. Do we support it or not?

Also want to be clear that node 15 is not experimental. It's as stable as any released software. It just is not considered LTS.

[kentcdodds]

Yeah, I think it would make sense to remove node from the list so we don't have unexpected surprises in the future. Technically we do support node 15 thanks to our >=10 listing in the package.json.

[MatanBobi]

I'm closing this one since @eps1lon opened #809

Thanks everyone :)