New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode disable option as it is not valid for postgres #94

Merged

morgante merged 1 commit into terraform-google-modules:master from AkhilGNair:master

Apr 24, 2020

Contributor

AkhilGNair commented Mar 10, 2020 •

edited

This removes backup_configuration.binary_log_enabled as an option in the postgres module, as attempting to set it as true results in an error:

Error: Error, failed to create instance <instance-name>: googleapi: Error 400: Invalid request: Binary log can only be enabled for MySQL instances., invalid

  on .terraform/modules/terraform-google-sql/modules/postgresql/main.tf line 26, in resource "google_sql_database_instance" "default":
  26: resource "google_sql_database_instance" "default" {


          Hardcode disable option as it is not valid for postgres

22f60ab

morgante approved these changes

View reviewed changes

morgante merged commit c74b15d into terraform-google-modules:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment